Skip to content

Handle SIGSEVs correctly #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arihant2math wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle SIGSEVs correctly #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/arch/arm64/memory/fault.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ use crate::{
memory::uaccess::UAccessResult,
},
memory::fault::{FaultResolution, handle_demand_fault, handle_protection_fault},
process::thread_group::signal::SigId,
sched::{current::current_task, spawn_kernel_work},
};
use alloc::boxed::Box;
Expand Down Expand Up @@ -119,15 +120,8 @@ pub fn handle_kernel_mem_fault(exception: Exception, info: AbortIss, state: &mut
pub fn handle_mem_fault(exception: Exception, info: AbortIss) {
match run_mem_fault_handler(exception, info) {
Ok(FaultResolution::Resolved) => {}
// TODO: Implement proc signals.
Ok(FaultResolution::Denied) => {
let task = current_task();
panic!(
"SIGSEGV on process {} {:?} PC: {:x}",
task.process.tgid,
exception,
task.ctx.user().elr_el1
)
current_task().process.deliver_signal(SigId::SIGSEGV);
}
// If the page fault involves sleepy kernel work, we can
// spawn that work on the process, since there is no other
Expand Down
Loading