Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route read-only raw Prisma queries to read replica #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Route read-only raw Prisma queries to read replica #1467
Changes from all commits
fd63a63caa521ce37c1e9dc81fb260fce4e8aed98dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read-after-write from replica in same request fails
Medium Severity
syncLocalEmulatorOnboardingStatusreads theProjecttable from the replica via$replica().$queryRaw, but the project may have just been created on the primary bygetOrCreateLocalEmulatorProjectIdin the same request (line 325→327). When the replica hasn't caught up, the query returns zero rows and throws aStackAssertionError, surfacing as a 500 to the user. The same pattern at line 86 can causegetOrCreateLocalEmulatorProjectIdto miss an existing mapping and orphan the old project. Before this PR both reads hit the primary, so no replication lag was possible. The default replication wait strategy is"none", meaning no wait occurs even when a real replica is configured.Additional Locations (2)
apps/backend/src/app/api/latest/internal/local-emulator/project/route.tsx#L85-L93apps/backend/src/app/api/latest/internal/local-emulator/project/route.tsx#L324-L327Reviewed by Cursor Bugbot for commit 8aed98d. Configure here.
Uh oh!
There was an error while loading. Please reload this page.