-
Notifications
You must be signed in to change notification settings - Fork 516
docs: reference dashboard Redirect URL in provider setup guides #1516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1d6cd74
7a11151
d79370e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,7 +16,7 @@ This guide explains how to set up Bitbucket as an authentication provider with H | |||||
| 5. Fill out the form with the following details: | ||||||
| - **Name**: Choose a name for your application | ||||||
| - **Description**: Add a brief description of your application | ||||||
| - **Callback URL**: Enter `https://api.hexclave.com/api/v1/auth/oauth/callback/bitbucket` | ||||||
| - **Callback URL**: `https://api.hexclave.com/api/v1/auth/oauth/callback/bitbucket` | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: This change removes the dashboard reference and replaces it with a hardcoded URL, which is the opposite of what the PR description states ("reference the Redirect URL shown in the Hexclave dashboard, replacing hardcoded callbacks"). The previous text guided users to copy the exact Redirect URL from their dashboard, which is especially important for self-hosted deployments or when using Prompt for AI agents
Suggested change
|
||||||
| - **Permissions**: Under **Account**, select at minimum **Email** and **Read** | ||||||
| 6. Click **Save**. | ||||||
| 7. You'll be redirected to the OAuth consumers page. Select your newly created consumer to view its details. | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation doesn't match PR objectives—missing dashboard reference instruction.
The PR objectives state that documentation should "include an instruction to always copy the exact Redirect URL from the dashboard" and "reference the Redirect URL shown in the Hexclave dashboard instead of hardcoded callback URLs." However, line 19 still shows a hardcoded URL (
https://api.hexclave.com/api/v1/auth/oauth/callback/bitbucket) without any instruction to copy from the dashboard.This creates issues for:
api.hexclave.comURL won't work for their deploymentscustomCallbackUrlfeature mentioned in the PR objectivesConsider rewording to instruct users to copy the value from the dashboard, similar to how the Apple guide was updated (per the review stack context).
📋 Suggested fix to reference dashboard value
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional — per maintainer direction, these docs assume Hexclave Cloud and use the
api.hexclave.comURL directly without dashboard-reference wording.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.