-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(cli): add skills version check, update, and freshness manifest #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
49ff19e
feat(cli): add skills version check, update, and freshness manifest
WaterrrForever c6105f9
fix(cli): add execFile to child_process mock in skills test
WaterrrForever 6961b21
feat(cli): init installs all skills; skills update pulls the full set
WaterrrForever 05b5d55
feat(cli): skills check treats missing skills as needing an update
WaterrrForever 8255774
fix(cli): install/update skills straight from the GitHub repo
WaterrrForever 8e3435f
feat(cli): init checks skills against GitHub, installs only when stale
WaterrrForever 1cf81c7
refactor(cli): address skills manifest review feedback
WaterrrForever 497faf6
fix(cli): strict skills update + auto-discover any agent host
WaterrrForever 5ac3a6c
fix(cli): resolve CodeQL file-system race + de-flake Windows npx test
WaterrrForever a743153
fix(cli): repair garbled npx smoke-test timeout comment
WaterrrForever File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| // Generate (or verify) skills-manifest.json (repo root) — the published | ||
| // "latest" fingerprint of the HyperFrames skill bundle. | ||
| // | ||
| // bun run --cwd packages/cli gen:skills-manifest # write/update | ||
| // bun run --cwd packages/cli gen:skills-manifest --check # verify only (CI) | ||
| // | ||
| // The manifest is just per-skill content hashes (no version / timestamp), so it | ||
| // is fully deterministic: same skill content ⇒ byte-identical manifest. `--check` | ||
| // exits non-zero when the committed manifest doesn't match current skill content. | ||
|
|
||
| import { readFileSync, writeFileSync } from "node:fs"; | ||
| import { dirname, join } from "node:path"; | ||
| import { fileURLToPath } from "node:url"; | ||
| import { buildManifest, MANIFEST_FILE, type SkillsManifest } from "../src/utils/skillsManifest.js"; | ||
|
|
||
| const here = dirname(fileURLToPath(import.meta.url)); | ||
| const repoRoot = join(here, "..", "..", ".."); // packages/cli/scripts → repo root | ||
| const skillsRoot = join(repoRoot, "skills"); | ||
| const outPath = join(repoRoot, MANIFEST_FILE); | ||
| const isCheck = process.argv.includes("--check"); | ||
|
|
||
| /** Stable signature of the content hashes (order-independent). */ | ||
| function signature(skills: SkillsManifest["skills"]): string { | ||
| return Object.keys(skills) | ||
| .sort() | ||
| .map((name) => `${name}:${skills[name]!.hash}`) | ||
| .join("\n"); | ||
| } | ||
|
|
||
| function driftLine(name: string, oldHash?: string, newHash?: string): string | null { | ||
| if (oldHash === newHash) return null; | ||
| if (!oldHash) return ` + ${name} (new)`; | ||
| if (!newHash) return ` - ${name} (removed)`; | ||
| return ` ~ ${name} (${oldHash} → ${newHash})`; | ||
| } | ||
|
|
||
| function hashOf(skills: SkillsManifest["skills"], name: string): string | undefined { | ||
| return skills[name]?.hash; | ||
| } | ||
|
|
||
| function reportDrift(fresh: SkillsManifest, committed: SkillsManifest | null): void { | ||
| const oldSkills = committed === null ? {} : committed.skills; | ||
| const names = [...new Set([...Object.keys(fresh.skills), ...Object.keys(oldSkills)])].sort(); | ||
| for (const name of names) { | ||
| const line = driftLine(name, hashOf(oldSkills, name), hashOf(fresh.skills, name)); | ||
| if (line) console.log(line); | ||
| } | ||
| } | ||
|
|
||
| const fresh = buildManifest(skillsRoot, { source: "heygen-com/hyperframes" }); | ||
|
|
||
| // Read the committed manifest directly (no existsSync precheck) so there's no | ||
| // check-then-write race on outPath — a missing or unreadable file just means | ||
| // "no committed manifest yet", and we write a fresh one below. | ||
| let committed: SkillsManifest | null = null; | ||
| try { | ||
| committed = JSON.parse(readFileSync(outPath, "utf8")) as SkillsManifest; | ||
| } catch { | ||
| committed = null; | ||
| } | ||
|
|
||
| const inSync = committed !== null && signature(committed.skills) === signature(fresh.skills); | ||
| const count = Object.keys(fresh.skills).length; | ||
|
|
||
| if (isCheck) { | ||
| if (inSync) { | ||
| console.log(`✓ ${MANIFEST_FILE} is in sync (${count} skills)`); | ||
| process.exit(0); | ||
| } | ||
| console.error(`✗ ${MANIFEST_FILE} is out of date — a skill changed without regenerating it.`); | ||
| reportDrift(fresh, committed); | ||
| console.error( | ||
| `\nRun: bun run --cwd packages/cli gen:skills-manifest (then commit ${MANIFEST_FILE})`, | ||
| ); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| // Write mode — churn-free: only rewrite when a content hash actually changed. | ||
| if (inSync) { | ||
| console.log(`${MANIFEST_FILE} already in sync — no change (${count} skills)`); | ||
| process.exit(0); | ||
| } | ||
|
|
||
| writeFileSync(outPath, JSON.stringify(fresh, null, 2) + "\n"); | ||
| console.log(`Wrote ${outPath} (${count} skills)`); | ||
| reportDrift(fresh, committed); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.