fix(studio): green up element-groups CI (file-size cap + non-sticky drill test)#1770
Merged
Conversation
…sticky drill test - extract deduplicateKeyframes + synthesizeFlatTweenKeyframes into gsapTweenSynth.ts so useGsapTweenCache.ts drops from 628 to 573 lines (600-line cap) - the drilled-into-group selection test asserted the old sticky behavior; the code is intentionally non-sticky (clicking outside exits the group and resolves the clicked element), so the test now asserts that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI reds landed on
mainwith the element-groups stack; this greens them.useGsapTweenCache.tscrossed the 600-line cap (588 → 628 via the timeline-expansion PR). Extracted the two pure synth helpers (deduplicateKeyframes,synthesizeFlatTweenKeyframes) intogsapTweenSynth.ts→ 573 lines.domEditingLayers'clicking outside the drilled-into group' asserted the old sticky behavior (null). The code is intentionally non-sticky (clicking outside exits the group and resolves the clicked element, per its comment). Test now asserts that.studio 1180/0, useGsapTweenCache 11/11, domEditingLayers 13/13, typecheck/lint/format clean.