docs: shadow-migration scope decision + CHANGELOG catch-up (#182–#192)#194
Merged
Conversation
… to #192 Wraps up the shadow-DOM migration: - header-controls.js: document why the header language selector / dark toggle stay in the light DOM by design — they are blend-in components that deliberately borrow Skilljar's own `headerheight align-vertical` classes to sit like native header items. Shadow-isolating them would sever exactly the styles they borrow and force hand-replicating the host header's metrics (brittle against Skilljar changes, no observed leak there). Overlay components with their own visual identity (FAB, sidebar, TOC) are the ones that live in #skillbridge-root. - CHANGELOG [Unreleased]: add the entries merged since the last batch — FAB icon collapse (#182, #183), reset-button host-blue leak (#185), "Claude(Claude)" gloss self-duplication (#187), chip alignment (#191), shadow-root isolation (#188–#190, #192), README telemetry wording (#186), capture:store → @starter-series/shotkit (#192). No behavior change (comment + changelog only).
heznpc
added a commit
that referenced
this pull request
Jun 9, 2026
Mechanical version cut so the dashboard upload ships everything merged since the 3.5.39 tag (#166–#194: Italian re-translation + locale guard, protected- terms CJK fix, tutor stream fixes, Gemini-verify guard, FAB icon + reset-button host-CSS fixes, "Claude(Claude)" gloss collapse, chip alignment, shadow-root isolation, doc consistency). - manifest.json / package.json / package-lock.json → 3.5.40 - 11 src/data/*.json _meta.version → 3.5.40 (check:dict-coverage enforces the match); claude-plugin terms data regenerated in sync - CHANGELOG: [Unreleased] → [3.5.40] - 2026-06-10; fresh [Unreleased] added - RELEASE_CHECKLIST refreshed for v3.5.40 (status block, prepared list, gate counts 520/520 + 19 e2e; historical 3.5.39 mentions kept) - STORE_LISTING → v3.5.40; "What's new" gains the 3.5.40 user-facing items (tutor-button icon, chip alignment, "Claude(Claude)" fix, style isolation) - README installation note + version markers (npm run docs) → 3.5.40 Artifacts rebuilt and verified at 3.5.40: store-assets/skillbridge-bundled.zip (CWS upload) + skillbridge.zip (raw fallback) — both gitignored, upload from local disk. Gates: 520 unit, full E2E 19/19, lint, prettier, validate, all check:* green (check:cws-drift intentionally fails until the dashboard upload).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap-up for the shadow-DOM migration.
header-controls.js — scope decision recorded in code
The header language selector / dark toggle stay in the light DOM by design: they are blend-in components that deliberately borrow Skilljar's own
headerheight align-verticalclasses to sit like native header items (header-controls.js:76). Shadow-isolating them would sever exactly the styles they borrow and force hand-replicating the host header's metrics — brittle against Skilljar header changes, for no benefit (no host-CSS leak observed there). Overlay components with their own visual identity (FAB, sidebar, TOC) are the ones isolated in#skillbridge-root(#188–#192).CHANGELOG
[Unreleased]caught up to #192Adds: FAB icon collapse (#182/#183) · reset-button host-blue leak (#185) · "Claude(Claude)" gloss self-dup (#187) · chip alignment (#191) · shadow-root isolation (#188–#190, #192) · README telemetry wording (#186) ·
capture:store→@starter-series/shotkit(#192).No behavior change (comment + changelog only). Lint/prettier/520 unit tests green locally; CI gates the rest.
🤖 Generated with Claude Code