fix(tutor): select-and-ask quote bar queried light DOM for shadow-rooted wrap#206
Merged
Conversation
…adow-rooted input wrap The stage-2b sweep-up in #205 fixed text-selection.js's chat-input lookup but missed the .si18n-chat-input-wrap lookup 17 lines above — document.querySelector returns null now that the sidebar lives in the shadow root, so the quoted-text bar silently never rendered. Found by the post-batch max-effort review; now uses sb.$() like its sibling. Gates: 527 unit, full E2E 20/20, lint, prettier green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Max-effort review of the #203–#205 batch caught one more stage-2b stragller:
text-selection.js:92still looked up.si18n-chat-input-wrapviadocument.querySelector— null since the sidebar moved into the shadow root (#190), so the quoted-text bar silently never rendered (#205 fixed the input lookup at :109 but missed this one 17 lines above). One-line fix tosb.$(). Gates: 527 unit · E2E 20/20 · lint · prettier green.🤖 Generated with Claude Code