Conversation
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
gerner
reviewed
Apr 12, 2024
Collaborator
gerner
left a comment
gerner
left a comment
There was a problem hiding this comment.
I'm excited to be able to run meshchat locally :)
| @@ -4,19 +4,42 @@ | |||
| # creates the filesystem image for the MeshChat API package. | |||
Collaborator
There was a problem hiding this comment.
is this still an accurate comment? it seems like the API package is dead and you're reusing the packaging scripts to build the debian package?
| return output | ||
| end | ||
|
|
||
| -- TODO remove AAMM specific parts |
Collaborator
There was a problem hiding this comment.
what is AAMM?
all of this stuff is for portability openwrt and debian?
| @@ -0,0 +1,10 @@ | |||
| Package: meshchat | |||
| Version: | |||
| Depends: lua5.4 | |||
Collaborator
There was a problem hiding this comment.
curl, gzip, some flavor of dnsutils (for nslookup) are also required. That's just from looking for shellouts:
$ ag 'capture' | less
www/jquery-2.2.0.min.js:2:!function(a,b){"object"==typeof module&&"object"==typeof module.exports?module.exports=a.document?b(a,!0):fun>
meshchatlib.lua:50:--- Execute a command and capture the output.
meshchatlib.lua:55:function capture(cmd)
meshchatlib.lua:131: local output = capture("md5sum " .. file:gsub(" ", "\\ ")):match("^(%S+)%s")
meshchatlib.lua:174: return capture("echo " .. os.time() .. math.random(99999) .. " | md5sum"):sub(1, 8)
meshchatlib.lua:216: local lines = capture("df -k " .. local_files_dir)
meshchatlib.lua:242: return capture("nslookup " .. hostname):match("Address 1:%s*([%d%.]+)")
$ ag 'popen' | less
support/meshchatsync:213: local f = io.popen("/usr/bin/curl --retry 0 --connect-timeout " .. connect_timeout .. " --speed-ti>
support/meshchatsync:236: f = io.popen("/usr/bin/curl --retry 0 --connect-timeout " .. connect_timeout .. " --speed-time " .>
support/meshchatsync:255: f = io.popen("/usr/bin/curl --retry 0 --connect-timeout " .. connect_timeout .. " --speed-time " .>
support/meshchatsync:266: f = io.popen("/usr/bin/curl --retry 0 --connect-timeout " .. connect_timeout .. " --speed-time " .>
meshchatlib.lua:56: local f = io.popen(cmd)
meshchat:218: output = io.popen("gzip", "w")
meshchat:727: local f = io.popen("/usr/bin/curl --retry 0 --connect-timeout " .. connect_timeout .. " --speed-time " .. speed_ti
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Debian packaging to MeshChat and removes the
lucilibraries so that MeshChat can function on a Linux OS.Closes #6