chore: Update .github/scripts/bot-inactivity-unassign.sh to skip if 'discussion' label is added by AkshayKumarSahu · Pull Request #1771 · hiero-ledger/hiero-sdk-python

AkshayKumarSahu · 2026-02-09T19:32:07Z

Description:

Related issue(s):

Fixes #1583

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: AkshayKumarSahu <akshaykumar15031999@gmail.com>

Copilot

Pull request overview

Updates the GitHub automation that unassigns users / closes stale PRs to not take action when a linked PR is intentionally parked for discussion via a discussion label (Fixes #1583).

Changes:

Add a discussion label check in the inactivity bot script to skip closing/unassigning when present.
Add a corresponding entry to CHANGELOG.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
`.github/scripts/bot-inactivity-unassign.sh`	Adds logic to detect the `discussion` label on linked PRs and skip inactivity actions.
`CHANGELOG.md`	Documents the new inactivity-bot behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/scripts/bot-inactivity-unassign.sh

CHANGELOG.md

.github/scripts/bot-inactivity-unassign.sh

coderabbitai · 2026-02-09T19:35:25Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds a check to the inactivity bot script to skip closing/unassigning PRs labeled "discussion" and logs skipped PRs; also updates CHANGELOG.md to record the new behavior.

Changes

Cohort / File(s)	Summary
Inactivity Bot Script `.github/scripts/bot-inactivity-unassign.sh`	Fetches PR labels, detects a `discussion` label, logs a skip message like `[SKIP] PR #<num> has 'discussion' label — skipping close & unassign`, and `continue`s to avoid closing or unassigning those PRs.
Changelog `CHANGELOG.md`	Adds an Unreleased entry documenting the inactivity bot now skips PRs with the `discussion` label.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: updating bot-inactivity-unassign.sh to skip PRs with 'discussion' label.
Description check	✅ Passed	The description references the linked issue `#1583` and briefly explains the purpose of the PR, which is related to the changeset.
Linked Issues check	✅ Passed	The code changes implement all primary requirements from issue `#1583`: adding a check for 'discussion' label, skipping PRs with that label, and updating the CHANGELOG [`#1583`].
Out of Scope Changes check	✅ Passed	All changes are scoped to the requirements in issue `#1583`: modifications to bot-inactivity-unassign.sh and CHANGELOG.md only, with no unrelated changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

.github/scripts/bot-inactivity-unassign.sh

CHANGELOG.md

exploreriii

Hi @AkshayKumarSahu
There are quite a lot of changes here

Testing this would be difficult, but is worthwhile and a good next challenge

Could you:

merge this PR to your forks main
change inactivity to just 10 minutes, for example
go to settings
enable issues
go to issues, create a label 'discussion'

try and trigger this bot, eg

create pull request
be inactive for 10 minutes, expect to unassign
create a pull request with 'discussion'
be inactive for 10 minutes, expect not to unassign
docs/sdk_developers/training/testing_forks.md

github-actions · 2026-02-10T11:56:32Z

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

Quick Fix for CHANGELOG.md Conflicts

If your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:

Click on the "Resolve conflicts" button in the PR
Accept both changes (keep both changelog entries)
Click "Mark as resolved"
Commit the merge

For all other merge conflicts, please read:

Thank you for contributing!

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

github-actions · 2026-02-11T10:23:53Z

Hello, this is the OfficeHourBot.

This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request.

Details:

Time: 14:00 UTC
Join Link: Zoom Meeting

Disclaimer: This is an automated reminder. Please verify the schedule here for any changes.

From,
The Python SDK Team

exploreriii · 2026-02-11T11:06:15Z

@AkshayKumarSahu I noticed you have still got this PR to rest and merge, which is essential to be able to complete the next workflow you want to be assigned.

I will unassign you from #1721 while you complete this workflow
Thank you for your understanding

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

AkshayKumarSahu · 2026-02-14T10:01:35Z

@AkshayKumarSahu I noticed you have still got this PR to rest and merge, which is essential to be able to complete the next workflow you want to be assigned.

I will unassign you from #1721 while you complete this workflow Thank you for your understanding

Sure go ahead, meanwhile i am testing the changes

exploreriii · 2026-02-15T10:09:04Z

HI @AkshayKumarSahu were you abel to test this, adn do you have screenshots or links to show?

AkshayKumarSahu · 2026-02-17T16:02:25Z

HI @AkshayKumarSahu were you abel to test this, adn do you have screenshots or links to show?

gonna work on this today

tech0priyanshu · 2026-02-18T15:28:36Z

Hii @AkshayKumarSahu Thanks for contribution and efforts. Please have a look on comment posted by coderabbitai[bot] Copilot code review

exploreriii · 2026-02-21T04:40:54Z

Hi @AkshayKumarSahu do you need any help with the testing please?

…n.sh - Add TEST_DOCUMENTATION.md: Complete test documentation with all test cases - Add TEST_EXECUTION_DETAILED.md: Detailed execution report with inputs/outputs - Add TEST_QUICK_REFERENCE.md: Quick reference guide for running tests - Add test-execution-log.txt: Raw test execution output (11/11 tests passed) Tests validate the discussion label protection feature that prevents auto-closing PRs labeled with 'discussion' regardless of inactivity.

- Comprehensive test suite with 8 test cases (11 assertions) - Mock system for GitHub CLI commands - Tests discussion label protection feature - All tests passing (11/11) - Includes setup, execution, validation, and cleanup

e branch '1583_1' of https://github.com/AkshayKumarSahu/hiero-sdk-python into 1583_1

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

exploreriii · 2026-02-23T18:10:55Z

Hi @AkshayKumarSahu have you read on how to test this on your fork please? docs/sdk_developers/training/testing_forks.md

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

exploreriii

Hi @AkshayKumarSahu would you please update us on the status of this PR?
I see some recent commits and want to check if it is tested on your fork and if you are ready for a review.
Also - i see some of your commits lost their signing DCO status, please check
Thanks

exploreriii

Hi @AkshayKumarSahu
Thanks for creating this and having a good go at the tests
This should be good to go

However, your DCO is not passing
can you check please these two commits are not signed correctly?
https://github.com/hiero-ledger/hiero-sdk-python/pull/1771/checks?check_run_id=65311182170

you can do
i = number of commits you want to soft revert
git reset --soft HEAD~i
then recommit and force push

exploreriii · 2026-03-06T21:49:24Z

Hi @AkshayKumarSahu as a reminder please rebase, correct the signing, and move your changelog entry to the new unreleased version 👍

chore: fixed discusstion label

c3e64eb

Signed-off-by: AkshayKumarSahu <akshaykumar15031999@gmail.com>

AkshayKumarSahu requested a review from a team as a code owner February 9, 2026 19:32

Copilot AI review requested due to automatic review settings February 9, 2026 19:32

AkshayKumarSahu requested a review from a team as a code owner February 9, 2026 19:32

AkshayKumarSahu requested review from leninmehedy and rbair23 February 9, 2026 19:32

Copilot started reviewing on behalf of AkshayKumarSahu February 9, 2026 19:32 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

.github/scripts/bot-inactivity-unassign.sh Show resolved Hide resolved

.github/scripts/bot-inactivity-unassign.sh Show resolved Hide resolved

CHANGELOG.md Show resolved Hide resolved

.github/scripts/bot-inactivity-unassign.sh Show resolved Hide resolved

coderabbitai bot reviewed Feb 9, 2026

View reviewed changes

.github/scripts/bot-inactivity-unassign.sh Show resolved Hide resolved

CHANGELOG.md Show resolved Hide resolved

AkshayKumarSahu added 2 commits February 10, 2026 01:09

Merge branch 'main' into 1583_1

2ac63da

Merge branch 'main' into 1583_1

91dd468

exploreriii requested changes Feb 10, 2026

View reviewed changes

exploreriii marked this pull request as draft February 10, 2026 11:54

exploreriii added the status: needs developer revision PR has requested changes that the developer needs to implement label Feb 10, 2026

Merge branch 'main' into 1583_1

cf41605

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

Merge branch 'main' into 1583_1

4be6419

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

AkshayKumarSahu marked this pull request as ready for review February 14, 2026 17:44

Merge branch 'main' into 1583_1

9a07b6e

Merge branch 'main' into 1583_1

fdbdd6a

exploreriii removed status: needs triage review PR needs a review from the triage team status: needs committer review PR needs a review from the committer team labels Feb 18, 2026

tech0priyanshu added the status: needs developer revision PR has requested changes that the developer needs to implement label Feb 18, 2026

exploreriii removed the status: needs developer revision PR has requested changes that the developer needs to implement label Feb 21, 2026

Akshat8510 marked this pull request as draft February 21, 2026 06:31

AkshayKumarSahu added 7 commits February 23, 2026 21:46

Merge branch 'main' into 1583_1

09829ea

Add executable test script test-bot-inactivity-unassign.sh

c92bbb5

- Comprehensive test suite with 8 test cases (11 assertions) - Mock system for GitHub CLI commands - Tests discussion label protection feature - All tests passing (11/11) - Includes setup, execution, validation, and cleanup

Mero

f083967

e branch '1583_1' of https://github.com/AkshayKumarSahu/hiero-sdk-python into 1583_1

Delete .github/scripts/TEST_QUICK_REFERENCE.md

68af11f

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

Delete .github/scripts/TEST_DOCUMENTATION.md

7600cb5

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

Delete .github/scripts/TEST_EXECUTION_DETAILED.md

884ac2f

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

AkshayKumarSahu added 4 commits February 24, 2026 00:07

Merge branch 'hiero-ledger:main' into 1583_1

c99475e

Delete .github/scripts/test-execution-log.txt

34dd7c8

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>

Merge branch 'main' into 1583_1

311dd27

Merge branch 'main' into 1583_1

0722464

exploreriii requested changes Mar 1, 2026

View reviewed changes

exploreriii added the status: needs developer revision PR has requested changes that the developer needs to implement label Mar 1, 2026

exploreriii requested changes Mar 3, 2026

View reviewed changes

exploreriii removed the status: needs developer testing label Mar 3, 2026

Conversation

AkshayKumarSahu commented Feb 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

exploreriii left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 10, 2026

Quick Fix for CHANGELOG.md Conflicts

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

exploreriii commented Feb 11, 2026

Uh oh!

AkshayKumarSahu commented Feb 14, 2026

Uh oh!

exploreriii commented Feb 15, 2026

Uh oh!

AkshayKumarSahu commented Feb 17, 2026

Uh oh!

tech0priyanshu commented Feb 18, 2026

Uh oh!

exploreriii commented Feb 21, 2026

Uh oh!

exploreriii commented Feb 23, 2026

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

exploreriii commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Feb 9, 2026 •

edited

Loading

exploreriii left a comment •

edited

Loading