fix: handle multi-dot filenames in fileExists extension check#1
Open
hikali123456789 wants to merge 1 commit into
Open
fix: handle multi-dot filenames in fileExists extension check#1hikali123456789 wants to merge 1 commit into
hikali123456789 wants to merge 1 commit into
Conversation
Previously, fileExists() used name.split('.')[1] to extract the file
extension, which failed for multi-dot filenames like 'my.asyncapi.yaml'
— retrieving 'asyncapi' instead of 'yaml'. This caused valid spec files
with multiple dots in their names to be rejected as having unsupported
extensions.
Fix: use split().pop() to get the last segment, correctly identifying
the actual file extension for any number of dots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
fileExists()function insrc/domains/models/SpecificationFile.tsusesname.split('.')[1]to extract the file extension. For multi-dot filenames likemy.asyncapi.yaml, this retrieves'asyncapi'instead of'yaml', causing valid spec files to be incorrectly rejected withErrorLoadingSpec.Fix
Use
split().pop()to get the last segment, correctly identifying the actual file extension for any number of dots.Changes
src/domains/models/SpecificationFile.ts: Fixed extension extraction ??split('.')[1]replaced withsplit().pop()test/unit/models/spec-file.test.ts: Added comprehensive unit tests covering single-dot filenames, multi-dot filenames, unsupported extensions, and edge cases