Dev3 popup keepupdating#240
Open
hiroshisuga wants to merge 116 commits intov3.0.x-releasefrom
Open
Conversation
Even when a sharescreen etc starts, the popup keeps the presentation container.
Finally it's fixed. Does this make other problems?
Seems to make no difference...
And add the comments on what is affected by these changes.
update 3.0.13
bump to 3.0.14
The style changing panel is now working properly.
|
This pull request has conflicts ☹ |
Previously, the popup window did not close when the meeting is closed with the popup opened.
Production modeにすると、popupでプレゼンが大きく下にシフトして表示される問題を修正。
…006_warning Dev3 popup revert suppress 3006 warning
Trying to add darkReader attributes to the HTML, which was successful, but the dark mode did not work.
The change that alters the color of the grab and grabbing cursor is reverted. This is a preparation of the new laser pointer implementation that follows now.
…h_targetDoc Replace redundant ternary operators: Eliminate all tedious "isPresentationDetached ? popup.document... : document..." ＋ More robust condition by "isPresentationDetached && popup?.document : ...."
Revert the previous change, which was a mistake.
Move a definition of useRef to the beginning, similar to the other useRefs.
Automated tests Summary🚨 Test workflow has failedClick here to check the action test reports (to view the report locally, see the docs) |
🚨 Automated tests failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes Issue(s)
Closes #
Motivation
More