Added new TimeSpan type and XOR operator#33
Open
brianhassel wants to merge 1 commit intohisystems:masterfrom
Open
Added new TimeSpan type and XOR operator#33brianhassel wants to merge 1 commit intohisystems:masterfrom
brianhassel wants to merge 1 commit intohisystems:masterfrom
Conversation
Owner
|
Hey Brian, Thanks for the pull request. It would be great to support Timespan as construct. So thanks for that. However, there are few things with the changes. Can you;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great project; thank you!
To understand it better, I added an XOR operator and a TimeSpan type. The TimeSpan is parsed like a typical System.TimeSpan wrapped in tick (ASCII 96) characters:
I changed the DateTime type to return a TimeSpan when subtracting 2 DateTimes, and a TS can be subtracted/added to a DT.
I'll also pull request my unit tests.