Skip to content

v1.0.0: Library API stability, new features, architectural changes & more - #7

Merged
hitblast merged 41 commits into
masterfrom
v1
May 8, 2026
Merged

v1.0.0: Library API stability, new features, architectural changes & more#7
hitblast merged 41 commits into
masterfrom
v1

Conversation

@hitblast

@hitblast hitblast commented May 5, 2026

Copy link
Copy Markdown
Owner

Updates will be documented on the CHANGELOG.md for this branch.

@hitblast hitblast self-assigned this May 5, 2026
@hitblast
hitblast marked this pull request as draft May 5, 2026 16:01
Sreehari425
Sreehari425 approved these changes May 5, 2026
View reviewed changes

@Sreehari425 Sreehari425 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpick you can rename SendableActivity -> ActivitySpec
techincaly user can get confused
SendableActivity indirectly implies that the data is ready to send
but infact it not , while under the hood it transforming and then send
aka the it should be ActivitySpec

@hitblast hitblast changed the title v1: SendableActivity, possible performance upgrades & more' v1: SendableActivity, possible performance upgrades & more May 5, 2026
@hitblast

hitblast commented May 5, 2026

Copy link
Copy Markdown
Owner Author

LGTM, minor nitpick you can rename SendableActivity -> ActivitySpec techincaly user can get confused SendableActivity indirectly implies that the data is ready to send but infact it not , while under the hood it transforming and then send aka the it should be ActivitySpec

Sure thing. I'll do that real quick.

@hitblast hitblast changed the title v1: SendableActivity, possible performance upgrades & more v1.0.0: Library stability, new features, architectural changes & more May 6, 2026
@hitblast hitblast changed the title v1.0.0: Library stability, new features, architectural changes & more v1.0.0: Library API stability, new features, architectural changes & more May 6, 2026
Sreehari425
Sreehari425 reviewed May 6, 2026
View reviewed changes

@Sreehari425 Sreehari425 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM :), btw you can drop rust editon from 2024 to 2021 and msrv is around 1.85.1 btw

@hitblast
hitblast marked this pull request as ready for review May 7, 2026 06:40
@hitblast
hitblast marked this pull request as draft May 7, 2026 18:52
@hitblast
hitblast marked this pull request as ready for review May 8, 2026 07:50
@hitblast
hitblast merged commit 6a90e98 into master May 8, 2026
1 check passed
@hitblast
hitblast deleted the v1 branch May 8, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Sreehari425 Sreehari425 Sreehari425 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@hitblast hitblast

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hitblast @Sreehari425