Skip to content

fix(recall): accept superseded claim history - #8

Closed
hjqcan wants to merge 1 commit into
mainfrom
codex/fix-superseded-claim-validation
Closed

fix(recall): accept superseded claim history#8
hjqcan wants to merge 1 commit into
mainfrom
codex/fix-superseded-claim-validation

Conversation

@hjqcan

@hjqcan hjqcan commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • distinguish all canonical facts from active canonical facts during projection validation
  • require claim status coverage only for active facts
  • retain claim/status history for superseded facts without reporting it as orphaned
  • keep truly deleted canonical facts subject to orphan cleanup

Runtime evidence

A Hermes GoodMemory v0.1.1 live smoke against published goodmemory@0.7.2 completed remember, new-session recall, workspace isolation, trace routing, revise, and forget, but emitted orphan_claim_status / orphan_claim validation warnings after the revised fact was superseded and the replacement was deleted.

The same live smoke against this branch completed the full loop with no projection-validation warning.

Verification

  • bun test tests/unit/recall.claim-revision-visibility.test.ts — 13 pass
  • bun test tests/unit/recall.claim-projection.test.ts — 32 pass
  • bun run typecheck — pass
  • Hermes live smoke against this branch — pass; new-session recall and workspace isolation true; revise/forget pass; warning absent
  • git diff --check — pass
  • bun test — 6296 pass, 62 skip, 1 fail across 6359 tests. The sole failure is the unrelated existing C3 physical-path assertion because this isolated clone lives under /tmp; the fixed-temporary-root guard fires before the overlap guard expected by tests/unit/codex-coding-effect.c3-pilot-options.test.ts.

@hjqcan

hjqcan commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

CI comparison after the first PR run:

Both CI gates fail only in tests/unit/run-v0-7-3-lifecycle-protection-gate.test.ts, beginning with claim recipe benchmark root must match the protected root. The PR adds one passing regression test and does not add a new failing test. I am leaving the check red and recording the baseline comparison rather than presenting the PR as fully green.

@hjqcan hjqcan closed this Aug 8, 2026
@hjqcan
hjqcan deleted the codex/fix-superseded-claim-validation branch August 8, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant