fix(recall): accept superseded claim history - #8
Closed
hjqcan wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
CI comparison after the first PR run:
Both CI gates fail only in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime evidence
A Hermes GoodMemory v0.1.1 live smoke against published
goodmemory@0.7.2completed remember, new-session recall, workspace isolation, trace routing, revise, and forget, but emittedorphan_claim_status/orphan_claimvalidation warnings after the revised fact was superseded and the replacement was deleted.The same live smoke against this branch completed the full loop with no projection-validation warning.
Verification
bun test tests/unit/recall.claim-revision-visibility.test.ts— 13 passbun test tests/unit/recall.claim-projection.test.ts— 32 passbun run typecheck— passgit diff --check— passbun test— 6296 pass, 62 skip, 1 fail across 6359 tests. The sole failure is the unrelated existing C3 physical-path assertion because this isolated clone lives under/tmp; the fixed-temporary-root guard fires before the overlap guard expected bytests/unit/codex-coding-effect.c3-pilot-options.test.ts.