Restore numpy>1.x compatibility - #52
Merged
Merged
Conversation
Contributor
Author
Owner
|
Thanks for the detailed explanation! Your reasoning makes sense to me. Are you using Python 3.9? I mean to remove Python 3.9 soon. |
Contributor
Author
No, I'm currently using 3.11 for most of my work, so removing 3.9 won’t affect me 👍 |
Contributor
|
Following up, this LGTM. Good call @prina404. I verified version 1.1.4 is still working with our downstream implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Proposal to partially revert the changes introduced in #49 in order to keep numpy 1.x compatibility.
My understanding of the error described in #49 is that the wheel was built with numpy 1.x, which is not forward-compatible with numpy 2.x.
But as long as the correct version is set with this option in
pyproject.tomlwe should be able to produce wheels that are backwards-compatible with 1.x. AFAIK, this is the standard approach to maintain compatibility (e.g. in SciPy's pyproject.toml)
Changes
Revert
requirements.txtandNPYmacros to version 1.21 (which should be the minimum numpy version for python 3.9)Notes
I've tested these changes by building a linux wheel with cibuildwheel and running it succesfully in two different clean environments with numpy>=2.0 and numpy<2.0 respectively.