Open
Conversation
Set a working directory for esplint
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 98.31% 98.34% +0.02%
==========================================
Files 11 16 +5
Lines 357 422 +65
Branches 47 66 +19
==========================================
+ Hits 351 415 +64
- Misses 6 7 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is dependent on #77
Right now after old and new stats have been collected, they are checked against only a single condition
whether the warnings have been increased or not. This PR introduces the concept ofguards. A guard is just a condition against which rule stats are checked. There are two guards provided by esplint right now.By default, the
warningsIncreasedguard will run. Other guards can be specified through the command line by using the following option:--guards=warningsReducedBy. The following command will enable the guard../index.js example/index.js --guards=warningsReducedByA new parameter has been introduced in
.esplintrccalled reduceWarningsBy. This value will be provided in the numerical equivalent of percentages. For example, to enforce reduction by 10% the value specified in the config will be 0.1