Merged
Conversation
Repro: Install spicyrando from modlinks, which PreloadHook-s Fungus1_21 I'm pretty sure this is not the most correct fix but I don't really want to figure out the most correct fix, this works and is pretty fast. Obviously the alpha/beta values can be improved but I didn't really want to do maths so I just split it 50/50
Contributor
Author
To be clear I believe what is happening here is that:
I think the ideal fix would do standard preloads with RepackAssets and preload hooks with RepackScene, or maybe everything with RepackScene in the same bundle? I don't know enough to implement a fix like this though |
Member
|
I'd say this needs like a more clear explanation in-line but I'd also want to split the stuff so that the stuff shared between objects and hooks gets only loaded the one time. I'll take a look at adjusting repacking for the hooks before though since that was mentioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: Install spicyrando from modlinks, which PreloadHook-s Fungus1_21
I'm pretty sure this is not the most correct fix but I don't really want to figure out the most correct fix, this works and is pretty fast.
Obviously the alpha/beta values can be improved but I didn't really want to do maths so I just split it 50/50