Fix: Only execute code if wp.media exists#3
Open
zcuric wants to merge 1 commit intohlashbrooke:masterfrom
Open
Fix: Only execute code if wp.media exists#3zcuric wants to merge 1 commit intohlashbrooke:masterfrom
zcuric wants to merge 1 commit intohlashbrooke:masterfrom
Conversation
zcuric
force-pushed
the
fix-missing-wp.media
branch
from
85d2370 to
e6f83d4
Compare
zcuric
force-pushed
the
fix-missing-wp.media
branch
from
e6f83d4 to
c5b22b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
wp.mediaexists so the script doesn't break if there is none and prevents code from executing.To reproduce this bug, use ACF and try to add new field group. In the console you can see the error:
