Add bun support + bump package.json deps#2
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c71317c47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "skipLibCheck": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "types": ["node"] | ||
| "types": ["node", "bun-types"] |
There was a problem hiding this comment.
compilerOptions.types entries are resolved by package name, and the dependency added here is @types/bun (which should be referenced as "bun"), not "bun-types". In a clean install this causes tsc to fail with “Cannot find type definition file for 'bun-types'”, which breaks npm run typecheck/CI for this commit until either bun-types is installed explicitly or the types entry is corrected.
Useful? React with 👍 / 👎.
2 participants
No description provided.