ARCPOC-1559#668
Merged
Merged
Conversation
- Batch-load, batch-delete, and batch-save officials for bulk update. - Replace per-official bulk audit events with a single bulk officials audit record. - Spill oversized audit payloads into CLOB-backed data-audit fields. - Update focused unit and integration tests for the new bulk officials behaviour.
- Batch bulk result validation and reuse resolved list, entry and result-code state. - Preserve bulk endpoint error semantics for missing entries versus wrong-list entries. - Keep bulk result persistence and auditing on the optimised batched path. - Add focused validator and controller test coverage for the batched behaviour.
# Conflicts: # src/main/java/uk/gov/hmcts/appregister/applicationentry/service/ApplicationEntryServiceImpl.java # src/main/java/uk/gov/hmcts/appregister/audit/listener/DataAuditLogger.java # src/test/java/uk/gov/hmcts/appregister/applicationentry/service/ApplicationEntryServiceImplTest.java
- Batch target-list resequencing for bulk entry moves. - Replace per-entry move auditing with a single bulk move audit payload. - Persist moved entries through the batched save path. - Update unit and integration tests for the bulk move audit and rollback behaviour.
- Add a dedicated bulk fees audit payload and operation. - Batch fee status and offsite fee persistence under one audit operation. - Update unit and integration tests for single-record bulk fee auditing.
- Reuse persisted bulk result entities after flush instead of reloading them. - Remove the redundant bulk result repository lookup from the service test. - Extract shared bulk audit formatting helpers and add focused tests.
- Add the bulk delete application entry results endpoint and request contract. - Implement atomic bulk validation and batched deletion for entry results. - Add a single bulk audit event capturing the requested and deleted result rows. - Add unit and integration coverage for successful bulk deletion and rollback on validation failure. - Update jackson 2.x to newer version.
philhead1
self-requested a review
July 21, 2026 13:43
philhead1
approved these changes
Jul 21, 2026
# Conflicts: # src/main/java/uk/gov/hmcts/appregister/applicationentry/service/ApplicationEntryServiceImpl.java
colbsure
marked this pull request as ready for review
July 21, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
https://tools.hmcts.net/jira/browse/ARCPOC-1559
Change description
The ask here is to optimise the bulk endpoints to perform in an acceptable duration - currently they seem to iterate over the lists and operate on singluar items rather than being a truly bulk implementation.
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist