[DD-42927] new REST endpoint to retrieve the list of hearing and associated cases for a given date#223
Merged
Conversation
natrajmolala
requested review from
JakeM-Kainos,
mkarakaya55 and
vikram-moj
and removed request for
a team
July 13, 2026 08:58
|
|
1 similar comment
|
|
|
|
|
|
1 similar comment
|
|
| return null; | ||
| } | ||
|
|
||
| private boolean shouldCaseBeIncluded(final Hearing hearing, final ProsecutionCase pc) { |
There was a problem hiding this comment.
@natrajmolala check with Simon if cases belonging to group proceedings (assuming these are civil) should not be included for our use case..
| @ServiceComponent(QUERY_VIEW) | ||
| private Requester requester; | ||
|
|
||
| @Inject |
There was a problem hiding this comment.
@natrajmolala this needs to be at the API layer and should throw AccessControlException.. see existing patterns.. we should not let this request go through even if its only returning empty list..
Contributor
Author
There was a problem hiding this comment.
Done! moved FeatureControlGuard to api layer and throw AccessControlViolationError (403) when not enabled
| public abstract List<Hearing> findHearings(@QueryParam("date") final LocalDate date, | ||
| @QueryParam("courtCentreId") final UUID courtCentreId); | ||
|
|
||
| @Query(value = "select h.*" + |
There was a problem hiding this comment.
@natrajmolala not good with SQL queries.. i am hoping you have double checked this and go claude's approval as well.. do run this past Satish as well
|
|
2 similar comments
|
|
|
|
jayenhc
approved these changes
Jul 20, 2026
…s for a date; with SystemUser permissions
…eryApi and throw exception when feature not enabled
natrajmolala
force-pushed
the
dev/dd-42927
branch
from
July 20, 2026 12:21
b6e2df2 to
361e168
Compare
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New endpoint: GET /hearing-cases-for-day?date=yyyy-MM-dd
Key changes:
master.
HearingForTodayIT.shouldRetrieveHearingCasesForDayForSystemUser.