pmdMain resolutions#1147
Open
llsamwinga wants to merge 85 commits into
Open
Conversation
…need to be permanently disqualified. (hmcts#1140) * task/JS-621 Excluded voters functionality * Update CreatePoolController_loadVotersWithExcluded.sql * Update CreatePoolController_createPool.sql * Update VotersServiceImpl.java * optimising exluded voters loop * Update V2_106__add_excluded_voters_table.sql * Update V2_109__add_excluded_voters_table.sql
… to be deceased (hmcts#1139) * task/JS-620 Deceased voters * Update CreatePoolController_createPool.sql * updating the way deceased voters are retrieved * optimising using a custom class * Update VotersServiceImpl.java * fixing merge conflicts
…nested if statement(s)
… boolean logic to single return statement, added relevant suppression(s)
…s), removed unused fields in processJurorAgeDisqualification method, inverted if condition(s)
…s), inverted if condition
… redundant braces, added final access modifier(s),
…ementation, inverted if condition
…y (for encapsulation purposes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")