PO-6392 - BacsStandard18 Format Processor - source JSON - #96
Open
Ben-Edwards-cgi wants to merge 4 commits into
Open
PO-6392 - BacsStandard18 Format Processor - source JSON#96Ben-Edwards-cgi wants to merge 4 commits into
Ben-Edwards-cgi wants to merge 4 commits into
Conversation
hmcts-jenkins-cnp
Bot
added
ns:opal
prd:opal
rel:opal-file-handler-service-pr-96
labels
Ben-Edwards-cgi
marked this pull request as ready for review
July 27, 2026 16:06
Comment on lines
+16
to
+19
| } catch (IOException ex) { | ||
| throw new IllegalArgumentException("BACS Standard 18 file could not be read", ex); | ||
| } catch (UncheckedIOException ex) { | ||
| throw new IllegalArgumentException("BACS Standard 18 file could not be read", ex); |
Contributor
There was a problem hiding this comment.
Can't these be collapsed into one catch ?
samnaylorcgi
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PO-6392
Change description
Depends on:
#91
#88
Does this PR introduce a breaking change? (check one with "x")