Skip to content

PO-9111 - change text on add offence button if no current offences#2902

Open
sarahtw-cgi wants to merge 2 commits into
masterfrom
PO-9111-change-text-on-add-offence-button
Open

PO-9111 - change text on add offence button if no current offences#2902
sarahtw-cgi wants to merge 2 commits into
masterfrom
PO-9111-change-text-on-add-offence-button

Conversation

@sarahtw-cgi

Copy link
Copy Markdown
Contributor

Jira link

https://tools.hmcts.net/jira/browse/PO-9111

Change description

  • If all offences are removed on the 'Offences and impositions' screen. Change the button text to 'Add an offence'
  • Ensure that if offences exist in the 'Offences and impositions' screen the button text still reads 'Add another offence'

Testing done

Added unit tests and did manual testing
Screenshot 2026-07-23 at 13 37 13

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

  • Yes
  • No

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change
  • [ ]
    No README changes needed and does not introduce a breaking change

@sarahtw-cgi

Copy link
Copy Markdown
Contributor Author

Build currently failing on functional tests. These are failing because a couple of tests can't find the button now that the name changes when no impositions exist

@sarahtw-cgi
sarahtw-cgi requested review from a team and louisbriggs July 24, 2026 14:40

@louisbriggs louisbriggs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahtw-cgi
sarahtw-cgi requested a review from a team July 24, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants