S28-3289 Refactor edit email notifications to use common notifier#1470
Open
lydiaralphgov wants to merge 39 commits into
Open
S28-3289 Refactor edit email notifications to use common notifier#1470lydiaralphgov wants to merge 39 commits into
lydiaralphgov wants to merge 39 commits into
Conversation
lydiaralphgov
commented
Jun 11, 2026
|
|
||
| @Slf4j | ||
| @Service | ||
| @SuppressWarnings("PMD.CouplingBetweenObjects") |
Contributor
Author
There was a problem hiding this comment.
whoop whoop another one bites the dust!
…ot trigger emails
lydiaralphgov
commented
Jun 11, 2026
lydiaralphgov
changed the title
lydiaralphgov
commented
Jul 21, 2026
| recording, | ||
| "{\"ffmpegInstructions\":[{\"start\":0,\"end\":60},{\"start\":120,\"end\":180}]}", | ||
| EditRequestStatus.PENDING, | ||
| EditRequestStatus.DRAFT, |
Contributor
Author
There was a problem hiding this comment.
Due to new restriction where edit request cannot be altered after submission
Contributor
Plan Result (stg)
Change Result (Click me) # module.pre-api-exception-alert[0].azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pre-stg/providers/Microsoft.Resources/deployments/PRE_API_exception"
name = "PRE_API_exception"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.pre_api[0].azurerm_api_management_api.api will be updated in-place
~ resource "azurerm_api_management_api" "api" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-stg/apis/pre-api;rev=999"
name = "pre-api"
# (17 unchanged attributes hidden)
~ import {
~ content_value = jsonencode(
~ {
~ components = {
~ schemas = {
~ CaptureSessionDTO = {
~ properties = {
- displayed_rtmps_link = {
- description = "CreateCaptureSessionDisplayedRtmpsLink"
- type = "string"
}
id = {
description = "CreateCaptureSessionId"
format = "uuid"
type = "string"
}
# (13 unchanged attributes hidden)
}
# (3 unchanged attributes hidden)
}
~ EntityModelCaptureSessionDTO = {
~ properties = {
- displayed_rtmps_link = {
- description = "CreateCaptureSessionDisplayedRtmpsLink"
- type = "string"
}
id = {
description = "CreateCaptureSessionId"
format = "uuid"
type = "string"
}
# (14 unchanged attributes hidden)
}
# (2 unchanged attributes hidden)
}
~ LiveEventDTO = {
~ properties = {
- displayed_rtmps_link = {
- description = "DisplayedRtmpsLink"
- type = "string"
}
id = {
description = "LiveEventId"
type = "string"
}
name = {
description = "LiveEventName"
type = "string"
}
# (3 unchanged attributes hidden)
}
# (2 unchanged attributes hidden)
}
# (83 unchanged attributes hidden)
}
# (1 unchanged attribute hidden)
}
tags = [
{
description = "Monitor and interact"
externalDocs = {
description = "Spring Boot Actuator Web API Documentation"
url = "https://docs.spring.io/spring-boot/docs/current/actuator-api/html/"
}
name = "Actuator"
},
]
# (6 unchanged attributes hidden)
}
)
# (1 unchanged attribute hidden)
}
# (1 unchanged block hidden)
}
# module.pre_b2c_product.azurerm_api_management_product.product will be updated in-place
~ resource "azurerm_api_management_product" "product" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-stg/products/pre-api-b2c"
~ subscriptions_limit = 0 -> 20
# (9 unchanged attributes hidden)
}
Plan: 0 to add, 3 to change, 0 to destroy. |
Contributor
Plan Result (prod)
Change Result (Click me) # module.pre-api-exception-alert[0].azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Resources/deployments/PRE_API_exception"
name = "PRE_API_exception"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.pre-api-liveness-alert[0].azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Resources/deployments/PRE_API_liveness"
name = "PRE_API_liveness"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.pre_api[0].azurerm_api_management_api.api will be updated in-place
~ resource "azurerm_api_management_api" "api" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/ss-prod-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-prod/apis/pre-api;rev=999"
name = "pre-api"
# (17 unchanged attributes hidden)
~ import {
~ content_value = jsonencode(
~ {
~ components = {
~ schemas = {
~ CaptureSessionDTO = {
~ properties = {
- displayed_rtmps_link = {
- description = "CreateCaptureSessionDisplayedRtmpsLink"
- type = "string"
}
id = {
description = "CreateCaptureSessionId"
format = "uuid"
type = "string"
}
# (13 unchanged attributes hidden)
}
# (3 unchanged attributes hidden)
}
~ EntityModelCaptureSessionDTO = {
~ properties = {
- displayed_rtmps_link = {
- description = "CreateCaptureSessionDisplayedRtmpsLink"
- type = "string"
}
id = {
description = "CreateCaptureSessionId"
format = "uuid"
type = "string"
}
# (14 unchanged attributes hidden)
}
# (2 unchanged attributes hidden)
}
~ LiveEventDTO = {
~ properties = {
- displayed_rtmps_link = {
- description = "DisplayedRtmpsLink"
- type = "string"
}
id = {
description = "LiveEventId"
type = "string"
}
name = {
description = "LiveEventName"
type = "string"
}
# (3 unchanged attributes hidden)
}
# (2 unchanged attributes hidden)
}
# (83 unchanged attributes hidden)
}
# (1 unchanged attribute hidden)
}
tags = [
{
description = "Monitor and interact"
externalDocs = {
description = "Spring Boot Actuator Web API Documentation"
url = "https://docs.spring.io/spring-boot/docs/current/actuator-api/html/"
}
name = "Actuator"
},
]
# (6 unchanged attributes hidden)
}
)
# (1 unchanged attribute hidden)
}
# (1 unchanged block hidden)
}
# module.pre_b2c_product.azurerm_api_management_product.product will be updated in-place
~ resource "azurerm_api_management_product" "product" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/ss-prod-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-prod/products/pre-api-b2c"
~ subscriptions_limit = 0 -> 20
# (9 unchanged attributes hidden)
}
Plan: 0 to add, 4 to change, 0 to destroy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket(s)
Change description
Important
This PR requires manual testing by QA. Please notify the QA team @hmcts/pre-rec-evidence-qa.
QA instructions
Notes:
Steps:
Test 1: Submitted email
Test 2: Rejected email