Make re-encoded recordings visible depending on flag#1514
Closed
lydiaralphgov wants to merge 9 commits into
Closed
Make re-encoded recordings visible depending on flag#1514lydiaralphgov wants to merge 9 commits into
lydiaralphgov wants to merge 9 commits into
Conversation
lydiaralphgov
commented
Jul 13, 2026
|
|
||
| @Service | ||
| @SuppressWarnings("PMD.CouplingBetweenObjects") | ||
| @SuppressWarnings({"PMD.CouplingBetweenObjects", "PMD.GodClass"}) |
Contributor
Author
There was a problem hiding this comment.
God class 😭 this class needs a bit of a tidy up, e.g. decommissioning the enable migrated flag, but not now
| return true; | ||
| } | ||
|
|
||
| return hideReencodedRecordings ^ recording.isReencode(); |
Contributor
Author
There was a problem hiding this comment.
^ means exclusive-or (one or the other is true, but not both)
Contributor
Author
|
Superseded by #1516 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket(s)
Change description
Logic:
Important
This PR requires manual testing by QA. Please notify the QA team @hmcts/pre-rec-evidence-qa.