Skip to content

Move offer asset resolution into Rust engine#93

Merged
hoffmang9 merged 6 commits into
mainfrom
feat/rust-cycle-bridge
May 29, 2026
Merged

Move offer asset resolution into Rust engine#93
hoffmang9 merged 6 commits into
mainfrom
feat/rust-cycle-bridge

Conversation

@hoffmang9
Copy link
Copy Markdown
Owner

Summary

  • Move offer asset normalization and Coinset fallback into the Rust engine with a single Python bridge (offer_assets_bridge).
  • Compose normalize-then-Coinset once in Python; expose coinset-only resolution as resolve_offer_assets_via_coinset (deprecated resolve_offer_asset_ids alias retained).
  • Align BLS and signer action builds on the same asset-resolution path when signer config is available; remove duplicate Python checks and dead adapter wrappers.

Test plan

  • pre-commit run --all-files (ruff, pyright, full pytest)
  • tests/test_offer_assets_bridge.py — real-engine normalize, collision, composition, and coinset fallback
  • Rust cargo test action:: including mockito coinset ticker resolution
  • Rebuild PyO3 extension in CI (maturin develop) before merge if not already in pipeline

Made with Cursor

hoffmang9 and others added 6 commits May 29, 2026 15:48
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Route runtime and adapter callers through resolve_offer_assets so normalization and Coinset fallback share one canonical path.

Co-authored-by: Cursor <cursoragent@cursor.com>
Compose normalize and Coinset paths once in Python, return PyO3 tuples, remove dead wrappers, and add real-engine bridge tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
Expose resolve_offer_assets_via_coinset as the canonical PyO3 path, pass signer config into BLS builds, and trim dead test mock server code.

Co-authored-by: Cursor <cursoragent@cursor.com>
@hoffmang9 hoffmang9 marked this pull request as ready for review May 29, 2026 23:39
@hoffmang9 hoffmang9 merged commit 2fd270b into main May 29, 2026
3 checks passed
@hoffmang9 hoffmang9 deleted the feat/rust-cycle-bridge branch May 29, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant