Move offer asset resolution into Rust engine#93
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Route runtime and adapter callers through resolve_offer_assets so normalization and Coinset fallback share one canonical path. Co-authored-by: Cursor <cursoragent@cursor.com>
Compose normalize and Coinset paths once in Python, return PyO3 tuples, remove dead wrappers, and add real-engine bridge tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Expose resolve_offer_assets_via_coinset as the canonical PyO3 path, pass signer config into BLS builds, and trim dead test mock server code. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
offer_assets_bridge).resolve_offer_assets_via_coinset(deprecatedresolve_offer_asset_idsalias retained).Test plan
pre-commit run --all-files(ruff, pyright, full pytest)tests/test_offer_assets_bridge.py— real-engine normalize, collision, composition, and coinset fallbackcargo test action::including mockito coinset ticker resolutionmaturin develop) before merge if not already in pipelineMade with Cursor