Skip to content

docs: move signing workflow to internal HR process#8

Merged
zolotokrylin merged 1 commit into
mainfrom
docs/consolidate-signing-process
Jun 10, 2026
Merged

docs: move signing workflow to internal HR process#8
zolotokrylin merged 1 commit into
mainfrom
docs/consolidate-signing-process

Conversation

@zolotokrylin

@zolotokrylin zolotokrylin commented Jun 10, 2026

Copy link
Copy Markdown
Member

What

Removes the "Workflow for Signing a Contractor Agreement" section (Steps 1–3) from the README, and replaces the detailed manual "Notify contractors" instructions in Step 6 with a single generic line.

Why

The signing workflow is an internal HR process and does not belong in a public repository. That detail is now maintained in holdex/hr-internal. The contractor-terms README should describe what the repo contains, not how HR operates internally.

The previous Step 6 described a manual email process that is now handled by an automated workflow in holdex/hr-internal.

Summary by CodeRabbit

  • Documentation
    • Updated standard terms workflow documentation with simplified contractor notification instructions. Replaced detailed notification requirements with an internal process. Documentation structure reorganized for improved clarity and logical flow.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15a519af-bf75-4960-9e2f-0fae0fbfd8f5

📥 Commits

Reviewing files that changed from the base of the PR and between 00906b8 and 7ed9b8b.

📒 Files selected for processing (1)
  • README.md

Walkthrough

README.md updates the standard terms update workflow by repositioning the section header and simplifying contractor notification instructions from explicit email requirements (content, subject format, 14-day effective date) to a single directive: notify active contractors per internal process.

Changes

Standard Terms Workflow Documentation

Layer / File(s) Summary
Contractor notification workflow documentation
README.md
Section header is repositioned after the signing workflow section ends. Contractor notification step is simplified from detailed email requirements (summary, release link, effective date minimum) to a brief "notify active contractors per your internal process" instruction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • holdex/contractor-terms#6: Prior PR aligned the standard terms update contractor-notification model away from email requirements; this PR simplifies the README instructions to match that workflow change.

Suggested reviewers

  • markholdex
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/consolidate-signing-process

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zolotokrylin zolotokrylin left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holdex submit-time 7m

@holdex

holdex Bot commented Jun 10, 2026

Copy link
Copy Markdown

Time Submission Status

Member # Time Running Total Status Last Update
@zolotokrylin - ❌ Missing

Submit or update total time with:

@holdex pr submit-time 2h

Add time on top of previous submission with:

@holdex pr add-time 1h30m

See available commands to help comply with our Guidelines.

@zolotokrylin
zolotokrylin marked this pull request as ready for review June 10, 2026 01:48
@zolotokrylin
zolotokrylin merged commit f2c264b into main Jun 10, 2026
2 of 4 checks passed
@zolotokrylin
zolotokrylin deleted the docs/consolidate-signing-process branch June 10, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant