Holidays issue-160 - Add region_names with iso 3166 english short names#325
Draft
ppeble wants to merge 8 commits into
Draft
Holidays issue-160 - Add region_names with iso 3166 english short names#325ppeble wants to merge 8 commits into
ppeble wants to merge 8 commits into
Conversation
ppeble
force-pushed
the
iso3166-region-names
branch
from
7678d94 to
1494cba
Compare
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Phil Peble <phil@peble.net>
ppeble
force-pushed
the
iso3166-region-names
branch
from
1494cba to
1e2e1bc
Compare
ttwo32
reviewed
May 5, 2026
| ### Naming conventions | ||
|
|
||
| - **ISO 3166-1 countries** (e.g. `:gb`, `:fr`): use the ISO 3166-1 common English name (e.g. `gb` is `"United Kingdom"`, not `"United Kingdom of Great Britain and Northern Ireland"`) | ||
| - **ISO 3166-2 subdivisions** (e.g. `:gb_eng`, `:de_by`): use the ISO 3166-2 official name, note that ISO 3166-2 names are in the official language of the country, not necessarily English (e.g. `de_by` is `"Bayern"`, not `"Bavaria"`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to holidays/holidays#160
We are adding a 'name' to each of the regions. These are iso 3166 english short names (in general). We will then update the downstream repos so that they process these values for human consumption.
We assume that i18n libraries will be able to parse the region code or the english short name here since they are based on iso 3166. In the cases where we have non-standard regions/names we will need to take that on a case by case basis. Some of this will be legacy stuff that will be hard to unravel without breaking changes, and we will address those individually.
The validation that is added should ensure that the iso 3166 structure is maintained going forward. We will rely on countries for this.
I propose that this is NOT a breaking change since it additive, and then there will be a matching downstream ruby gem update to process these in a comprehensive way.