Fix FR definitions : Pentecote Sunday is not a official public holiday in france, only the Monday#328
Merged
Conversation
abenhamdine
force-pushed
the
fix-fr-definitions
branch
from
68df1e1 to
f185caa
Compare
abenhamdine
changed the title
abenhamdine
changed the title
Signed-off-by: Arnaud Benhamdine <abenhamdine@users.noreply.github.com>
abenhamdine
force-pushed
the
fix-fr-definitions
branch
from
f185caa to
ea9fc6e
Compare
ppeble
approved these changes
Apr 27, 2026
Member
ppeble
left a comment
ppeble
left a comment
There was a problem hiding this comment.
Thank you for this! I will be merging a few more things and releasing 9.2.0 tonight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change made in this commit f07de65 is wrong and should have not been accepted :
So the definition was correct before that change and this PR revert the change.
You can see the official French definition of public holidays in the French law here :
https://www.legifrance.gouv.fr/codes/section_lc/LEGITEXT000006072050/LEGISCTA000006178007/
There are 11 official public holidays (and 2 more in region Alsace-Moselle which are not mentionned in this article)
You can find also find the official list for 2026 here on the French public administration website : https://www.service-public.gouv.fr/particuliers/actualites/A18558
The current definition error prevent us from updating the gem version, we are stuck on version 8.4.1 because of that.