This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Open
Conversation
Removed some code which could add a code action to the result from a query multiple times.
BlazeMCworld
approved these changes
Oct 29, 2022
Contributor
BlazeMCworld
left a comment
BlazeMCworld
left a comment
There was a problem hiding this comment.
approve, even though im not a maintainer
homchom
suggested changes
Nov 1, 2022
Owner
homchom
left a comment
homchom
left a comment
There was a problem hiding this comment.
I believe the point of this code was to prioritize exact matches. So, keep it in, but add an else before the next if to prevent duplicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed some code which could add a code action to the result from a query multiple times.
resolves #1