This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Adds the ability for custom instruments to have the names designated in the .nbs file imported.#66
Open
mudkip989 wants to merge 55 commits intohomchom:mainfrom
Open
Adds the ability for custom instruments to have the names designated in the .nbs file imported.#66mudkip989 wants to merge 55 commits intohomchom:mainfrom
mudkip989 wants to merge 55 commits intohomchom:mainfrom
Conversation
…dded my noteblock funnies.
…dded my noteblock funnies.
# Conflicts: # build.gradle.kts # gradle.properties # src/main/java/io/github/homchom/recode/Main.java # src/main/java/io/github/homchom/recode/Recode.kt # src/main/java/io/github/homchom/recode/event/trial/DetectorImpl.kt # src/main/java/io/github/homchom/recode/event/trial/ToggleRequesterGroup.kt # src/main/java/io/github/homchom/recode/feature/Feature.kt # src/main/java/io/github/homchom/recode/feature/automation/AutoCommands.kt # src/main/java/io/github/homchom/recode/feature/visual/BuiltInResourcePacks.kt # src/main/java/io/github/homchom/recode/feature/visual/CodeSearch.kt # src/main/java/io/github/homchom/recode/feature/visual/ExpressionHighlighting.kt # src/main/java/io/github/homchom/recode/feature/visual/SignRenderDistance.kt # src/main/java/io/github/homchom/recode/hypercube/CommandSenders.kt # src/main/java/io/github/homchom/recode/hypercube/message/MessageParser.kt # src/main/java/io/github/homchom/recode/hypercube/state/DFStateDetectors.kt # src/main/java/io/github/homchom/recode/mixin/multiplayer/MClientPacketListener.java # src/main/java/io/github/homchom/recode/mixin/render/chat/MChatComponent.java # src/main/java/io/github/homchom/recode/mixin/render/chat/MCommandSuggestions.java # src/main/java/io/github/homchom/recode/mod/commands/impl/text/ColorsCommand.java # src/main/java/io/github/homchom/recode/mod/events/impl/LegacyReceiveChatMessageEvent.java # src/main/java/io/github/homchom/recode/mod/features/LagslayerHUD.java # src/main/java/io/github/homchom/recode/mod/features/social/chat/message/LegacyMessage.java # src/main/java/io/github/homchom/recode/mod/features/social/chat/message/finalizers/DebugFinalizer.java # src/main/java/io/github/homchom/recode/mod/mixin/message/MMessageListener.java # src/main/java/io/github/homchom/recode/mod/mixin/render/MInGameHUD.java # src/main/java/io/github/homchom/recode/multiplayer/MultiplayerEvents.kt # src/main/java/io/github/homchom/recode/sys/player/chat/ChatUtil.java # src/main/java/io/github/homchom/recode/sys/sidedchat/ChatPredicates.java # src/main/java/io/github/homchom/recode/ui/text/MiniMessageHighlighter.kt # src/main/java/io/github/homchom/recode/ui/text/StyleWrapper.kt # src/main/java/io/github/homchom/recode/ui/text/StyledString.kt # src/main/java/io/github/homchom/recode/ui/text/TextBuilders.kt # src/main/java/io/github/homchom/recode/ui/text/TextInterop.kt # src/main/java/io/github/homchom/recode/util/coroutines/CoroutinesFunctions.kt # src/main/java/io/github/homchom/recode/util/coroutines/YieldingExecutorDispatcher.kt # src/main/resources/assets/recode/lang/en_us.json # src/main/resources/recode.mixins.json # src/main/resources/resourcepacks/better_unicode/pack.mcmeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously (and for a long time) whenever the nbs decoder would load a song with custom instruments, It would ignore the names and use "<Custom Instrument #1>" and so on for each Custom Instrument. With this request, the names are not discarded and are only "<Custom Instrument 1>" and so on, if the string for the name is null, whitespace characters, or empty. This small change allows for custom instruments to be set for the song much faster after importing.