Skip to content

Fix DIMSE handlers, event logging, and infra#165

Open
Vib3ss wants to merge 2 commits into
honeynet:GSoC-2026from
Vib3ss:GSoC-2026
Open

Fix DIMSE handlers, event logging, and infra#165
Vib3ss wants to merge 2 commits into
honeynet:GSoC-2026from
Vib3ss:GSoC-2026

Conversation

@Vib3ss
Copy link
Copy Markdown

@Vib3ss Vib3ss commented Jun 3, 2026

Closes #158, closes #164.

Pre work:

  • Rewrote docker-compose.yml
  • Wrote docs for quick start & installation

#158 DIMSE handlers:

  • Rewrote bind() with two variants per pynetdicom's handler contract
  • Added handle_echo, fixed handle_store (event.dataset), replaced
    handle_move with capture-and-reject (0xA801, logs destination AE)
  • Fixed Repository.init (supported_sop, engine, session)

#164 Honeypot logging:

  • Fixed new_bus() missing FileHandler
  • Fixed EventMessage serialization bugs (pdu, datetime, status)
  • Added bulk-data exclusion in parse_event() to prevent OOM
  • Added Docker json-file log rotation

@MayADevBe MayADevBe requested review from MayADevBe and RicYaben June 3, 2026 10:58
@MayADevBe
Copy link
Copy Markdown
Collaborator

Code style looks good from my side.

Here are the discussed things:

  • testing of handlers with DCMTK and Viewer (like Santesoft) - Do they behave like a normal system?
  • 2 types of logging 1. developer logging (this is done now) and honeypot interactions logging (this is open) (check pervious version + examples I will send)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants