Skip to content

Introduced ruff linter and formatter as pre-commit githook#109

Open
scopplestone wants to merge 2 commits intomainfrom
pre.commit.install.ruff.githook
Open

Introduced ruff linter and formatter as pre-commit githook#109
scopplestone wants to merge 2 commits intomainfrom
pre.commit.install.ruff.githook

Conversation

@scopplestone
Copy link
Copy Markdown
Collaborator

Introduced ruff linter and formatter pre-commit githook, which is configured via .pre-commit-config.yaml and pyproject.toml

@scopplestone scopplestone requested a review from kopperp March 11, 2026 10:46
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 11, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2987 2684 90% 85% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f76d407 by action🐍

Copy link
Copy Markdown
Collaborator

@kopperp kopperp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the pre-commit itself but I feel like we should move the documentation to a developer guide. Let's extend our docs before merging this PR.

@kopperp kopperp marked this pull request as draft March 13, 2026 16:18
@kopperp kopperp self-assigned this Mar 13, 2026
@kopperp kopperp added the enhancement New feature or request label Mar 13, 2026
@kopperp kopperp added this to the v0.11.0 milestone Mar 13, 2026
@kopperp kopperp force-pushed the pre.commit.install.ruff.githook branch from 1df4c64 to 0d0fb07 Compare March 18, 2026 10:34
kopperp added 2 commits March 18, 2026 11:36
…e.multiple.BCs

Output the BC index when running into the error of finding multiple BCs on the same internal face
@kopperp kopperp force-pushed the pre.commit.install.ruff.githook branch from 0d0fb07 to f76d407 Compare March 18, 2026 10:37
@kopperp kopperp marked this pull request as ready for review March 18, 2026 12:05
@kopperp kopperp self-requested a review March 18, 2026 12:05
@kopperp
Copy link
Copy Markdown
Collaborator

kopperp commented Mar 25, 2026

Are we good to ship this with the new developer guide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants