Skip to content

Bugfix: Correct FEM edge ordering and orientation#122

Draft
OttTs wants to merge 2 commits intohopr-framework:mainfrom
OttTs:bugfix.FEM.edges
Draft

Bugfix: Correct FEM edge ordering and orientation#122
OttTs wants to merge 2 commits intohopr-framework:mainfrom
OttTs:bugfix.FEM.edges

Conversation

@OttTs
Copy link
Copy Markdown

@OttTs OttTs commented Mar 27, 2026

Fixes FEM output by:

  • Ordering element-local edge IDs according to the CGNS convention.
  • Adding (correct) orientations in the EdgeInfo array by using signed EdgeIDs.

@kopperp kopperp self-requested a review March 27, 2026 18:23
@kopperp kopperp self-assigned this Mar 27, 2026
@kopperp kopperp added the bug Something isn't working label Mar 27, 2026
@kopperp kopperp added this to the v0.11.0 milestone Mar 27, 2026
@kopperp
Copy link
Copy Markdown
Collaborator

kopperp commented Mar 27, 2026

Thanks for the fixes. Does it make sense to FEM to some of the analyze.toml, so we can find future regressions?

@OttTs
Copy link
Copy Markdown
Author

OttTs commented Apr 1, 2026

Sure, that would be useful. The FEM output is still not fully working even for a structured 3D box, though, so I'm trying to get that sorted first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants