fix(mime-viewer): sanitize charset parameter containing full MIME type - #5
Merged
Merged
Conversation
Some buggy mailers set the charset to an invalid value (e.g. charset="text/html") instead of a valid character set name, causing a fatal error when attempting to convert the character set. Fall back to UTF-8 when the charset value is unambiguously invalid (i.e. does not match [a-zA-Z0-9_-]).
jcdelepine
force-pushed
the
fix/charset-content-type
branch
from
August 3, 2026 12:51
92ac1ec to
23d3f11
Compare
ralflang
approved these changes
Aug 5, 2026
Member
|
Thank you. Do you have a sample of such a buggy mailer software or created mail so I can add a unit test? |
Contributor
Author
|
As you can see, this mailer uses And horde said : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some buggy mailers set the charset parameter to the full MIME type (e.g. charset="text/html") instead of a valid character set name, causing a fatal error when attempting to convert the character set. Fall back to UTF-8 when the charset value contains a slash, which is a reliable indicator of a misplaced MIME type.