Skip to content

Add option in code for colon suffixs#4

Open
LucHayward wants to merge 1 commit into
hostar:masterfrom
LucHayward:colon-suffix
Open

Add option in code for colon suffixs#4
LucHayward wants to merge 1 commit into
hostar:masterfrom
LucHayward:colon-suffix

Conversation

@LucHayward

Copy link
Copy Markdown

No description provided.

@LucHayward

Copy link
Copy Markdown
Author

Helps add feature request #3 @hostar .
Still to do:

  • Need to add the option check box in the settings page to enable
  • Check whether the paramName passed to addSink() must also have the suffix added

@hostar

hostar commented Nov 23, 2021

Copy link
Copy Markdown
Owner

I appreciate your interest, but I don't like accepting this.
I think it make sense to accept the MR only if you either add the settings there or hardcode the colon with the passing of the unit tests here:
https://github.com/hostar/python-inlay-putter/blob/master/src/test/java/io/github/hostar/pythonInlay/InlayTests.java

If you don't feel like it, I can try to do this over the weekend.

@LucHayward

Copy link
Copy Markdown
Author

For sure, I agree it shouldn't be accepted until its feature complete. I just wanted to open it with my initial work in case others wanted to complete it before I had time to dig further and see what else needed to be done. Is there a better way to have done that?

@hostar

hostar commented Nov 29, 2021

Copy link
Copy Markdown
Owner

No, that is great approach. Thanks for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants