Refactored: Shop listing status message for products not linked to specific store.#338
Open
poorvishuklaa wants to merge 1 commit intohotwax:mainfrom
Open
Refactored: Shop listing status message for products not linked to specific store.#338poorvishuklaa wants to merge 1 commit intohotwax:mainfrom
poorvishuklaa wants to merge 1 commit intohotwax:mainfrom
Conversation
poorvishuklaa
changed the title
| </ion-label> | ||
| <ion-label v-else color="medium" slot="end"> | ||
| <h5>{{ $t("Not linked") }}</h5> | ||
| <h5>{{ $t("Product not sold on this shop") }}</h5> |
Contributor
There was a problem hiding this comment.
I don't think this will be correct according to suggested UI in the issue as shown below,
In the following change, the label is placed in the end slot, which displays it on the right side of the ion-item. However, in the suggested UI, there is nothing on the right side of the item. Instead, this message should appear as a sub-label beneath the main label, aligned to the left side.
| <h5>{{ $t("No listing data") }}</h5> | ||
| </ion-label> | ||
| <ion-label v-else color="medium" slot="end"> | ||
| <h5>{{ $t("Not linked") }}</h5> |
Contributor
There was a problem hiding this comment.
Check if this text is used elsewhere or not, if not. Remove it's entry from the locale file for translation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Product not linked to Shopify Store #254
Short Description and Why It's Useful
To show a relavant message if a product is not linked to specific store.