fix: set tag type to uint8_t#437
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | -1 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the internal representation of cell tagging flags by making samurai::CellFlag use an 8-bit underlying type and adjusting call sites to cast to std::uint8_t when writing/reading tag bitmasks.
Changes:
- Change
CellFlagtoenum class CellFlag : std::uint8_t. - Update tagging code paths to use
static_cast<std::uint8_t>(CellFlag::...)instead ofstatic_cast<int>(...). - Reformat a small block in
algorithm/utils.hppwhile updating casts.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| include/samurai/cell_flag.hpp | Switch CellFlag underlying type to std::uint8_t. |
| include/samurai/io/from_geometry.hpp | Update tag assignments/bit-tests to use std::uint8_t casts. |
| include/samurai/algorithm/utils.hpp | Update keep-tag propagation to use std::uint8_t casts and minor formatting. |
| include/samurai/algorithm/update.hpp | Update coarsen/keep/refine mask checks to use std::uint8_t casts. |
| include/samurai/algorithm/graduation.hpp | Update refine/keep mask propagation and tag checks to use std::uint8_t casts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| namespace samurai | ||
| { | ||
| enum class CellFlag | ||
| enum class CellFlag : std::uint8_t |
| [&](std::size_t level, const auto& i, const auto& index) | ||
| { | ||
| tag(level, i, index[0], index[1]) = static_cast<int>(CellFlag::keep); | ||
| tag(level, i, index[0], index[1]) = static_cast<std::uint8_t>(CellFlag::keep); |
Comment on lines
5
to
10
| #pragma once | ||
|
|
||
| namespace samurai | ||
| { | ||
| enum class CellFlag | ||
| enum class CellFlag : std::uint8_t | ||
| { |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the size of the cell tagging bitmask by making samurai::CellFlag explicitly use an 8-bit underlying type (std::uint8_t) and updates key tagging call sites to operate on std::uint8_t values consistently.
Changes:
- Switch
samurai::CellFlagtoenum class CellFlag : std::uint8_t(and include<cstdint>). - Store geometry-import tag fields as
std::uint8_tinstead ofint. - Update adaptation/tagging bitmask reads/writes to cast
CellFlagvalues tostd::uint8_t.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/samurai/cell_flag.hpp | Defines CellFlag with std::uint8_t underlying type and adds <cstdint> include. |
| include/samurai/io/from_geometry.hpp | Changes the internal tag scalar field storage to std::uint8_t and updates assignments/bit tests accordingly. |
| include/samurai/algorithm/utils.hpp | Updates CellFlag bitwise OR writes to std::uint8_t (with one remaining static_cast<int>(flag) noted). |
| include/samurai/algorithm/update.hpp | Updates refine/keep/coarsen bitmask checks to use std::uint8_t casts. |
| include/samurai/algorithm/graduation.hpp | Updates refine/keep/coarsen bitmask checks and propagation to use std::uint8_t casts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -123,15 +123,16 @@ namespace samurai | |||
| { | |||
| auto mask = (tag(level, i, j, k) & static_cast<int>(flag)); | |||
gouarin
added a commit
that referenced
this pull request
May 4, 2026
🤖 I have created a release *beep* *boop* --- ## [0.30.0](v0.29.2...v0.30.0) (2026-05-04) ### Features * ND projection and prediction operator ([#435](#435)) ([55829ab](55829ab)) ### Bug Fixes * mesh_config in load ([#438](#438)) ([7f43222](7f43222)) * set tag type to `uint8_t` ([#437](#437)) ([44e2ce7](44e2ce7)) ### Performance Improvements * improve tag computation ([#436](#436)) ([b0aadc5](b0aadc5)) * optimizations of local non-linear solvers ([#439](#439)) ([f0eedea](f0eedea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the internal representation of cell tagging flags by making
samurai::CellFlaguse an 8-bit underlying type and adjusting call sites to cast tostd::uint8_twhen writing/reading tag bitmasks.Changes:
CellFlagtoenum class CellFlag : std::uint8_t.static_cast<std::uint8_t>(CellFlag::...)instead ofstatic_cast<int>(...).Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct