Pass Gateway response if Issuer response is empty#15
Pass Gateway response if Issuer response is empty#15fpolowood wants to merge 17 commits intohps:masterfrom
Conversation
|
Fixes #16 |
Added more Transaction types and Services
|
Hi @fpolowood! Apologies for the delay, and thanks for the contribution. We'll get this reviewed and will follow up as soon as we can. |
slogsdon
left a comment
slogsdon
left a comment
There was a problem hiding this comment.
Again, apologies for the delay. We're going to attempt to get this PR released next Tuesday, so if you're unable to address the requested changes, please let us know so we can tackle them on our end.
Thanks!
| tx.CardData = {}; | ||
| tx.CardData.ManualEntry = hlp.hydrateCardData(card); | ||
| if (typeof(card)==='string'){ | ||
| tx.CardData.TrackData = card; |
There was a problem hiding this comment.
For track data, we'll need to have the ability to set the method attribute of the TrackData data field as either swipe or proximity to allow for contactless as well, so it may be better to pass the track data as an object similar to our other SDKs. You can reference our .NET SDK: Data Class, Hydration.
Also, our gateway supports encrypted track data (a large portion of the readers are encrypted with Heartland's End-To-End Encryption [E3]), so it would be nice to have this capability as well. You can reference our .NET SDK: Data Class, Hydration.
2 participants
When 'list'ing the Issuer response is always favored over the Gateway response, but in the case of Capture, the Issuer is empty and Gateway is relevant. So, if Issuer is empty, return Gateway, both for the code and the text.