This repository was archived by the owner on Feb 27, 2025. It is now read-only.
Open
Conversation
This should allow users to report by individual Device IDs. Reporting by individual Device IDs is useful for merchant using multiple Portico devices.
slogsdon
suggested changes
Jan 31, 2019
| * @throws \HpsInvalidRequestException | ||
| */ | ||
| public function listTransactions($startDate, $endDate, $filterBy = null) | ||
| public function listTransactions($startDate, $endDate, $deviceId = null, $filterBy = null) |
Contributor
There was a problem hiding this comment.
Let's swap $deviceId and $filterBy parameters to retain backwards compatibility for potential current users of $filterBy.
| $hpsReportActivity = $xml->createElement('hps:ReportActivity'); | ||
| $hpsReportActivity->appendChild($xml->createElement('hps:RptStartUtcDT', $startDate)); | ||
| $hpsReportActivity->appendChild($xml->createElement('hps:RptEndUtcDT', $endDate)); | ||
| if ($deviceId != null) { |
Contributor
There was a problem hiding this comment.
Let's use strict inequality here (!==) or check for non-empty (!empty($deviceId)). The choice between those two should depend on how the gateway treats empty values for the DeviceId data element.
| $hpsReportActivity->appendChild($xml->createElement('hps:RptEndUtcDT', $endDate)); | ||
| if ($deviceId != null) { | ||
| $hpsReportActivity->appendChild($xml->createElement('hps:DeviceId', $deviceId)); | ||
| }; |
Contributor
There was a problem hiding this comment.
This trailing semicolon isn't necessary.
slogsdon
approved these changes
Feb 1, 2019
Contributor
|
Looks good. We'll get this included in the next deployment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow users to report by individual Device IDs. Reporting by individual Device IDs is useful for merchant using multiple Portico devices.