Changed the parent prototype class for GeomXspline#65
Open
mtorchiano wants to merge 1 commit intohrbrmstr:masterfrom
Open
Changed the parent prototype class for GeomXspline#65mtorchiano wants to merge 1 commit intohrbrmstr:masterfrom
mtorchiano wants to merge 1 commit intohrbrmstr:masterfrom
Conversation
In order to get a similar result as the base graphics `xspline` function, the base proto class has to be a path and not a line. Fixing issue hrbrmstr#34
Author
|
The failure is not related to the proposed change there is a general problem in setting up the VM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to get a similar result as the base graphics
xsplinefunction, the base proto class has to be a path and not a line.In most cases there will be no difference, although in all the cases when the order of the control points has not an increasing x variable the result with a line will be a jittered output (see bug report #64 for details)
Fixes issue #64