Open
Conversation
generation errors during build
Owner
|
@jedmund this is increadible! I'm sorry I missed this PR and only noticed it now, I've abstracted the storage to support vercel's blob too, so there might need to be a bit of a rewrite needed but I'm happy to get this in otherwise. Would you mind updating the readme / deployment guide too? |
Author
|
Yeah, work got a bit busy (read: I need to lock in) but I will get to it before the weekend is over! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for building with Docker and self-hosting images with MinIO.
This makes three changes to actual app files:
src/app/(auth)/sign-up/page.tsx: Force dynamic rendering to prevent build failuressrc/lib/r2.ts: AddedS3_ENDPOINTand helper methods to switch between self-hosted storage and R2 storagesrc/server/api/routers/upload.ts: Update some messages to properly address using S3-compatible storage