reCAPTCHA v3, protection of BGP summary, and assorted bug fixes#46
Open
vettamatt wants to merge 14 commits intohsdn:masterfrom
Open
reCAPTCHA v3, protection of BGP summary, and assorted bug fixes#46vettamatt wants to merge 14 commits intohsdn:masterfrom
vettamatt wants to merge 14 commits intohsdn:masterfrom
Conversation
- Added hiding of BGP summary and command line for public-facing LG's - Added safe subnets array to permit some subnets to view peer information - Added RADb to footer - Stopped hyperlinks being added for private ASNs - Minor code formatting changes
- Fixed AS information in traceroute - Improved safe subnets message
Merg into test branch
reCAPTCHA v3 and assorted bug fixes Peer developed with @mrjwilz
scamp
suggested changes
Jan 13, 2024
| $url = @parse_url($url); | ||
|
|
||
| $routing_instance = $_CONFIG['routers'][$router]['routing-instance']; | ||
| $routing_instance = isset($_CONFIG['routers']) AND isset($_CONFIG['routers'][$router]) AND isset($_CONFIG['routers'][$router]['routing-instance']) ? $_CONFIG['routers'][$router]['routing-instance'] : null; |
There was a problem hiding this comment.
Please check, this code with PHP 8.1 always returns 1
| $_CONFIG['showpeerinfo'] = 'TRUE'; | ||
|
|
||
| /* | ||
| * If 'showpeerinfo' above is TRUE, and you would like to show BGP peer information to visitors from a specific IPv4 address or subnet, add the IPv4 address or subnet (in CIDR format) to the array below |
There was a problem hiding this comment.
Please clarify the comment, according to the code 'showpeerinfo' should be "FALSE" to filter peer info based on visitors IP.
|
Also please consider disabling reCaptcha for safe IP list, and disable AS_PATH manipulation, as it makes LG unusable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed reCAPTCHA v3 so have implemented this.
We found that the HSDN WHOIS wasn't working all the time, so switched this to RADb.
We implemented the ability to protect BGP summary information based upon the source IP address of the end user.
We have also fixed the following minor bugs that we encountered during development:
Peer developed with @mrjwilz