Prepare chefCriteria for CRAN submission#8
Open
NNcino wants to merge 4 commits into
Open
Conversation
- Remove Remotes block (chef and chefStats submitted simultaneously) - Bump version from 0.0.1.9000 to 0.1.0 - Title case: "A Collection of 'chef' Criterion Functions" - Expand Description to 3 sentences - Add BugReports field - Remove unused Imports (magrittr, purrr, dplyr, knitr) — none are referenced in NAMESPACE or active R code - Move knitr to Suggests (only needed as VignetteBuilder) - Tidy URL field, remove codecov URL - Create NEWS.md with initial release entry Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove VignetteBuilder/knitr (no vignettes exist)
- Move chef from Imports to Suggests (only used in tests, not in R code)
- Add dplyr and purrr to Suggests (used in test helpers)
- Add .pre-commit-config.yaml, .githooks, README.rmd, cran-plan.md to
.Rbuildignore to suppress non-standard top-level file NOTEs
- Fix {ramnog} -> \pkg{ramnog} in crit_by_strata_by_trt.R and
crit_bb_pval_01.Rd
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Test Results1 files 2 suites 1s ⏱️ Results for commit 556d6db. ♻️ This comment has been updated with latest results. |
…AN submission Adds Remotes: hta-pharma/chef@feature/CRAN_submission and hta-pharma/chefStats@feature/CRAN_submission so GitHub Actions can resolve those dependencies from GitHub during CI (neither is on CRAN yet). CRAN forbids Remotes: in submitted tarballs, so tools/strip-remotes.R removes the field before R CMD build. The helper restores DESCRIPTION afterwards when invoked with --build, leaving the working tree unchanged. Both tools/ and cran-plan.md are ignored at build time. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Code coverage
|
Github pagesReview the pkgdown webpage for the PR here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prepares the chefCriteria package for CRAN submission by fixing R CMD check issues, adding comprehensive documentation examples, and updating build configuration.
Changes
Fixed R CMD check issues for CRAN compliance
.Rbuildignoreconfiguration for proper package buildingAdded examples to all 3 exported functions
crit_bb_nsubev_01(): Example demonstrating minimum subject count criterioncrit_bb_pval_01(): Example showing p-value threshold criterioncrit_ep_nsubev_01(): Example for endpoint-specific criteria.Rddocumentation files with runnable examplesUpdated package metadata
Testing