42 add forest plot

[jinjliu]

Forest plot function added along with test files.

[github-actions]

Code Coverage Summary

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------
R/binary-helper.R          72       7  90.28%   14, 18, 21, 24, 28, 31, 36
R/bucher.R                 62       5  91.94%   103, 107, 111, 186-187
R/maic_anchored.R         499      46  90.78%   93-100, 105-108, 112, 115, 119, 122-125, 128-131, 136, 141, 144, 157, 166-171, 226, 306, 312, 317-321, 554, 560, 565-569
R/maic_forest_plot.R      203      17  91.63%   40, 43, 49, 75, 79, 96-99, 113-115, 128-133
R/maic_unanchored.R       303      36  88.12%   85-92, 95-96, 101, 104-107, 110-113, 118, 127, 130, 143, 157-164, 193, 259, 266, 268, 414, 421, 423
R/matching.R              252      25  90.08%   73-75, 83, 104, 131, 152, 188, 227, 282-283, 295-296, 335, 352, 412-413, 501-505, 547-549
R/plot_km.R               450      46  89.78%   56, 59, 62, 81-111, 302, 305-307, 322-325, 357, 413, 493, 496, 499, 511-512
R/plot_km2.R              109      23  78.90%   53, 62, 65, 68, 77, 94-100, 127-135, 138, 186
R/process_data.R          102      22  78.43%   45, 60-63, 69, 81-82, 162, 200, 245-261
R/survival-helper.R        30       1  96.67%   61
R/time-helper.R            20       3  85.00%   31, 57-58
R/utils.R                  24       9  62.50%   11-20
R/zzz.R                     1       1  0.00%    2
TOTAL                    2127     241  88.67%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  -------
R/maic_forest_plot.R     +203     +17  +91.63%
TOTAL                    +203     +17  +0.31%

Results for commit: c04b6ca

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[jinjliu]

@gravesti Hi Isaac, I tagged you as the reviewer for the initial forest plot function (Per our previous discussion, more discussions and updates are needed for the function). Please let me know if you have time to review or if you have some suggestions/thought. Greg also suggested that alternatively, I can put the function under design folder to bypass some of the lintr issue. Let me know what you think. Thank you!

[MikeJSeo]

Thanks for the nice code and nice plot! Works great!
I have reviewed it briefly.
Some comments I had:

• I think if bootstrap is run it should report bootstrap CI instead of default sandwich CI. So maybe check if bootstrap results are there.. and if there is replace it..
• Can you add a line in the vignettes: maybe just in unanchored_survival and anchored survival.Rmd a line that showcases this forest plot function? Maybe this you can do at the end..
• I put in a comment for case name change.. I think this makes better sense - to DISCUSS
• Let's put a dummy example instead of dontrun :)
• Need to Remove dplyr ggplot2 dependencies. Discuss about patchwork package dependency

[jinjliu]

There is a R CMD error after I removed dplyr, ggplot2 and patchwork from import. Is that ok?
Also the bot kept reformatting the code in conflict with the lintr check, which gave me the lintr failure. This we should be able to ignore?
Thanks again for reviewing!

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
maic_forest_plot	👶		$+0.67$	$+3$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
maic_forest_plot	👶		$+0.67$	maic_forest_plot_works_for_TTE

Results for commit 9f6876d

♻️ This comment has been updated with latest results.

[github-actions]

Unit Tests Summary

  1 files   11 suites   12s ⏱️
 43 tests  43 ✅ 0 💤 0 ❌
142 runs  142 ✅ 0 💤 0 ❌

Results for commit c04b6ca.