test(helper): Add waitUntilAllAsyncImagesAreLoaded #11
Open
mrloop wants to merge 2 commits intohtml-next:masterfrom
Open
test(helper): Add waitUntilAllAsyncImagesAreLoaded #11mrloop wants to merge 2 commits intohtml-next:masterfrom
mrloop wants to merge 2 commits intohtml-next:masterfrom
Conversation
Test helper to wait until all images are loaded
Build was failing without this * bump travis node version to LTS * update npm version
Author
|
Doesn't look like it's building, will need to update CI, see emberjs/rfcs#696. Would moving to Github actions be best solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test helper to wait until all images are loaded.
Also update travis node and npm version so project builds.
See updated README