Skip to content

trace: show error message when fork fails in TraceScreen #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dengzhongyuan365-dev wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −5
Open

trace: show error message when fork fails in TraceScreen #2036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39ff873
trace: show error message when fork fails in TraceScreen
dengzhongyuan365-dev Jul 1, 2026
76e7f5d
trace: preserve errno across close() calls in error path
dengzhongyuan365-dev Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Action.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,10 +674,8 @@ static Htop_Reaction actionStrace(State* st) {
assert(Object_isA((const Object*) p, (const ObjectClass*) &Process_class));

TraceScreen* ts = TraceScreen_new(p);
bool ok = TraceScreen_forkTracer(ts);
if (ok) {
InfoScreen_run((InfoScreen*)ts);
}
TraceScreen_forkTracer(ts);
InfoScreen_run((InfoScreen*)ts);
TraceScreen_delete((Object*)ts);
clear();
CRT_enableDelay();
Expand Down
16 changes: 15 additions & 1 deletion TraceScreen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,16 @@ void TraceScreen_delete(Object* cast) {
free(InfoScreen_done((InfoScreen*)this));
}

static void TraceScreen_scan(InfoScreen* super) {
TraceScreen* this = (TraceScreen*) super;
if (!this->strace_alive) {
char* err = NULL;
xAsprintf(&err, "%s", strerror(errno));
InfoScreen_addLine(super, err);
free(err);
Comment on lines +66 to +69

@Explorer09 Explorer09 Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a fixed size buffer and avoid an allocation here. The reason: Avoid a crash in an out of memory situation.

Suggested change
char* err = NULL;
xAsprintf(&err, "%s", strerror(errno));
InfoScreen_addLine(super, err);
free(err);
char err[64];
snprintf(err, sizeof(err), "%s", strerror(errno));
InfoScreen_addLine(super, err);

}
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

static void TraceScreen_draw(InfoScreen* this) {
InfoScreen_drawTitled(this, "Trace of process %d - %s", Process_getPid(this->process), Process_getCommand(this->process));
}
Expand Down Expand Up @@ -125,11 +135,14 @@ bool TraceScreen_forkTracer(TraceScreen* this) {

return true;

err:
err: {
int saved_errno = errno;
close(fdpair[1]);
close(fdpair[0]);
errno = saved_errno;
return false;
}
}

static void TraceScreen_updateTrace(InfoScreen* super) {
TraceScreen* this = (TraceScreen*) super;
Expand Down Expand Up @@ -209,6 +222,7 @@ const InfoScreenClass TraceScreen_class = {
.extends = Class(Object),
.delete = TraceScreen_delete
},
.scan = TraceScreen_scan,
.draw = TraceScreen_draw,
.onErr = TraceScreen_updateTrace,
.onKey = TraceScreen_onKey,
Expand Down