Skip to content

Screens/Tabs/Signals panels: move const calc expression out of loop #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GermanAizek wants to merge 1 commit into from
+5 −3
Closed

Screens/Tabs/Signals panels: move const calc expression out of loop #2040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ScreenTabsPanel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ static void ScreenNamesPanel_delete(Object* object) {
Panel* super = &this->super;

/* do not delete screen settings still in use */
int n = Panel_size(super);
const int n = Panel_size(super);
for (int i = 0; i < n; i++) {
ScreenNameListItem* item = (ScreenNameListItem*) Panel_get(super, i);
item->ss = NULL;
Expand Down
3 changes: 2 additions & 1 deletion ScreensPanel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ void ScreensPanel_cleanup(void) {

static void ScreensPanel_cancelMoving(ScreensPanel* this) {
Panel* super = &this->super;
for (int i = 0; i < Panel_size(super); i++) {
const int n = Panel_size(super);
for (int i = 0; i < n; i++) {
ListItem* item = (ListItem*) Panel_get(super, i);
if (item)
item->moving = false;
Expand Down
3 changes: 2 additions & 1 deletion SignalsPanel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ Panel* SignalsPanel_new(int preSelectedSignal) {
#if (defined(SIGRTMIN) && defined(SIGRTMAX))
if (SIGRTMAX - SIGRTMIN <= 100) {
static char buf[16];
for (int sig = SIGRTMIN; sig <= SIGRTMAX; i++, sig++) {
int sig = SIGRTMIN;
for (; sig <= SIGRTMAX; i++, sig++) {
int n = sig - SIGRTMIN;
xSnprintf(buf, sizeof(buf), "%2d SIGRTMIN%-+3d", sig, n);
if (n == 0) {
Expand Down
Loading