Open
Conversation
Owner
|
Cool, thank you for this. I'll review soon. |
|
nice to see some improvements in this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant as a spiritual continuation of #55, implemented by using the evdev attributes instead of file paths. I'm doing the comparison inside Inspector to ensure we stop processing a device as soon as possible (i.e. before we create a writer for the device)
The default behaviour with
device-allowlistunset is the same as before: All inputs found will be forwardedIf you configure the device-allowlist, only the devices matching at least 1 of the config options will be forwarded
Example configs
I currently support
name,vendor-id, andproduct-idfor filtering, and they're all either exact matches if they're set, or no check at all if they're unset.Happy to change things as you see fit!